Allow setting a sampler for an Image asset #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasEi
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Hey, thank you for the PR. I like the idea!
One general concern: What happens currently when we load the same path with different samplers? Looking through the code, I would expect that both fields would point to the same handle and that the sampler annotation from the last field would "win". Maybe we can check if the current sampler is the same and if not, clone the asset and replace the handle with a new one pointing to the modified copy?
Please run cargo fmt in the derive crate to get the CI green.
NiklasEi
reviewed
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.