Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpb: init at unstable-2018-07-27 #134148

Merged
merged 1 commit into from
Aug 15, 2021
Merged

bpb: init at unstable-2018-07-27 #134148

merged 1 commit into from
Aug 15, 2021

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 15, 2021

Motivation for this change

Signing my git commits without GPG

How to set up

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Signed this commmit with the tool.
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Member Author

jtojnar commented Aug 15, 2021

Does not look very maintained, e.g. this update PR from 2019: withoutboats/pbp#1

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Aug 15, 2021

The project is dead since 3 years.

And since we are not adopting the RFC we can close this PR.

@jtojnar
Copy link
Member Author

jtojnar commented Aug 15, 2021

It still works. And I wanted to package this few years ago already, the RFC only reminded me about it.

@SuperSandro2000 SuperSandro2000 merged commit 81900b1 into NixOS:master Aug 15, 2021
@jtojnar jtojnar deleted the bpb branch August 15, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants