Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ethers.WebSocketProvider tests #279

Closed
Wodann opened this issue Jan 25, 2024 · 1 comment · Fixed by NomicFoundation/hardhat#4842
Closed

Fix ethers.WebSocketProvider tests #279

Wodann opened this issue Jan 25, 2024 · 1 comment · Fixed by NomicFoundation/hardhat#4842
Assignees
@fvictorio
Milestone
EDR v0.2.0

Comments

@Wodann
Copy link
Member

Wodann commented Jan 25, 2024 •
edited
Loading

Definition of Done
Fix ethers.WebSocketProvider tests and move file from test-edr-failing to test
@Wodann Wodann added this to EDR Jan 25, 2024
@Wodann Wodann converted this from a draft issue Jan 25, 2024
@Wodann Wodann added this to the EDR v0.2.0 milestone Jan 25, 2024
@Wodann
Copy link
Member Author

Wodann commented Jan 30, 2024

I looked into this a little. The only failing test is "contract events work".

I confirmed that the contract is created and that the contract.modifiesState(1) call has the same transaction response between EthereumJS and EDR (the only difference being the block hash, but that's expected). For some reason, the Promise onContractEvent that is returned is never triggered though, causing a timeout.

@Wodann Wodann linked a pull request Feb 12, 2024 that will close this issue
test: re-enable ws test NomicFoundation/hardhat#4842
Merged
@Wodann Wodann moved this from Todo to Done in EDR Feb 12, 2024
@Wodann Wodann closed this as completed Feb 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fvictorio fvictorio

Labels
None yet
Projects
EDR
Status: Done
Milestone
EDR v0.2.0
Development

Successfully merging a pull request may close this issue.

test: re-enable ws test NomicFoundation/hardhat
2 participants
@fvictorio @Wodann