Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-enable ws test #4842

Merged
merged 4 commits into from
Feb 12, 2024
Merged

test: re-enable ws test #4842

merged 4 commits into from
Feb 12, 2024

Conversation

fvictorio
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1410dae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 7:58pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 9, 2024
@fvictorio fvictorio requested a review from Wodann February 9, 2024 08:26
@Wodann Wodann changed the title Re-enable ws test test: re-enable ws test Feb 12, 2024
@Wodann Wodann merged commit f0f5ca6 into edr/main Feb 12, 2024
101 of 102 checks passed
@Wodann Wodann deleted the edr/websocket-test branch February 12, 2024 15:57
@Wodann Wodann linked an issue Feb 12, 2024 that may be closed by this pull request
Fix ethers.WebSocketProvider tests NomicFoundation/edr#279
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ethers.WebSocketProvider tests
2 participants
@fvictorio @Wodann