Skip to content

Commit

Permalink
remove TODOs for external nodes because no longer needed
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristopherDedominici committed Dec 17, 2024
1 parent 0d806e1 commit 1851d3a
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 55 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ describe("INTEGRATION: changeEtherBalance matcher", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe.skip("connected to a hardhat node", ()=> {
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
let sender: HardhatEthersSigner;
let receiver: HardhatEthersSigner;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ describe("INTEGRATION: changeEtherBalances matcher", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// process.env.CHAIN_ID = "12345";
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
let sender: HardhatEthersSigner;
let receiver: HardhatEthersSigner;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ describe(
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

afterEach(() => {
clearTokenDescriptionsCache();
});
Expand Down
6 changes: 0 additions & 6 deletions v-next/hardhat-chai-matchers/test/matchers/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@ describe(".to.emit (contract events)", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
let ethers: HardhatEthers;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ describe("INTEGRATION: Reverted", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
// deploy Matchers contract before each test
let matchers: MatchersContract;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ describe("INTEGRATION: Reverted with", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
// deploy Matchers contract before each test
let matchers: MatchersContract;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ describe("INTEGRATION: Reverted with custom error", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
// deploy Matchers contract before each test
let matchers: MatchersContract;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ describe("INTEGRATION: Reverted with panic", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
// deploy Matchers contract before each test
let matchers: MatchersContract;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ describe("INTEGRATION: Reverted without reason", { timeout: 60000 }, () => {
runTests();
});

// TODO: when V3 node is ready, add this functionality
// describe("connected to a hardhat node", ()=>{
// useEnvironmentWithNode("hardhat-project");
// runTests();
// });

function runTests() {
// deploy Matchers contract before each test
let matchers: MatchersContract;
Expand Down

0 comments on commit 1851d3a

Please sign in to comment.