Make chainId optional in the EDR network configs

NomicFoundation · Oct 28, 2024 · 99603b9 · 99603b9
1 parent 110d09f
commit 99603b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/v-next/hardhat/src/internal/builtin-plugins/network-manager/hook-handlers/config.ts b/v-next/hardhat/src/internal/builtin-plugins/network-manager/hook-handlers/config.ts
@@ -220,7 +220,7 @@ export async function resolveUserConfig(
     if (networkConfig.type === "edr") {
       const resolvedNetworkConfig: EdrNetworkConfig = {
         type: "edr",
-        chainId: networkConfig.chainId,
+        chainId: networkConfig.chainId ?? 31337,
         chainType: networkConfig.chainType,
         from: networkConfig.from,
         gas: resolveGasConfig(networkConfig.gas),
@@ -229,7 +229,7 @@ export async function resolveUserConfig(
         // TODO: This isn't how it's called in v2
         forkConfig: networkConfig.forkConfig,
         hardfork: networkConfig.hardfork ?? "cancun",
-        networkId: networkConfig.networkId ?? networkConfig.chainId,
+        networkId: networkConfig.networkId ?? networkConfig.chainId ?? 31337,
         blockGasLimit: networkConfig.blockGasLimit ?? 12_500_000,
         minGasPrice: BigInt(networkConfig.minGasPrice ?? 0),
         automine: networkConfig.automine ?? true,

diff --git a/v-next/hardhat/src/internal/builtin-plugins/network-manager/type-extensions/config.ts b/v-next/hardhat/src/internal/builtin-plugins/network-manager/type-extensions/config.ts
@@ -78,7 +78,7 @@ declare module "../../../../types/config.js" {
 
   export interface EdrNetworkUserConfig {
     type: "edr";
-    chainId: number;
+    chainId?: number;
     chainType?: ChainType;
     from?: string;
     gas?: GasUserConfig;