Merge pull request #5877 from NomicFoundation/alternative-test-messages

Change how we print the titles of the test tasks
NomicFoundation · Oct 29, 2024 · b7fb81b · b7fb81b
2 parents 2ebd3c9 + 4c4234e
commit b7fb81b
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 8 deletions.
diff --git a/v-next/hardhat-mocha-test-runner/src/task-action.ts b/v-next/hardhat-mocha-test-runner/src/task-action.ts
@@ -52,6 +52,10 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
 
   const files = await getTestFiles(testFiles, hre.config);
 
+  if (files.length === 0) {
+    return;
+  }
+
   const tsx = fileURLToPath(import.meta.resolve("tsx/esm"));
   process.env.NODE_OPTIONS = `--import ${tsx}`;
 
@@ -81,6 +85,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
   }
   testsAlreadyRun = true;
 
+  console.log("Running Mocha tests");
+
   // This instructs Mocha to use the more verbose file loading infrastructure
   // which supports both ESM and CJS
   await mocha.loadFilesAsync();

diff --git a/v-next/hardhat-node-test-runner/src/task-action.ts b/v-next/hardhat-node-test-runner/src/task-action.ts
@@ -61,6 +61,10 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
 
   const files = await getTestFiles(testFiles, hre.config);
 
+  if (files.length === 0) {
+    return 0;
+  }
+
   const tsx = fileURLToPath(import.meta.resolve("tsx/esm"));
   process.env.NODE_OPTIONS = `--import ${tsx}`;
 
@@ -79,6 +83,9 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
       testOnlyMessage,
     });
 
+    console.log("Running node:test tests");
+    console.log();
+
     const reporterStream = run(nodeTestOptions)
       .on("test:fail", (event) => {
         if (event.details.type === "suite") {

diff --git a/v-next/hardhat/src/internal/builtin-plugins/solidity-test/task-action.ts b/v-next/hardhat/src/internal/builtin-plugins/solidity-test/task-action.ts
@@ -34,6 +34,13 @@ const runSolidityTests: NewTaskActionFunction<TestActionArguments> = async (
     )
   ).filter((artifact) => artifact !== undefined);
 
+  if (testSuiteIds.length === 0) {
+    return;
+  }
+
+  console.log("Running Solidity tests");
+  console.log();
+
   const config = {
     projectRoot: hre.config.paths.root,
   };

diff --git a/v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts b/v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts
@@ -570,6 +570,8 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
   }
 
   async #downloadConfiguredCompilers(quiet = false): Promise<void> {
+    // TODO: For the alpha release, we always print this message
+    quiet = false;
     if (this.#downloadedCompilers) {
       return;
     }

diff --git a/v-next/hardhat/src/internal/builtin-plugins/test/task-action.ts b/v-next/hardhat/src/internal/builtin-plugins/test/task-action.ts
@@ -1,9 +1,5 @@
 import type { NewTaskActionFunction } from "../../../types/tasks.js";
 
-import chalk from "chalk";
-
-import { formatTaskId } from "../../core/tasks/utils.js";
-
 interface TestActionArguments {
   noCompile: boolean;
 }
@@ -19,14 +15,11 @@ const runAllTests: NewTaskActionFunction<TestActionArguments> = async (
   }
 
   for (const subtask of thisTask.subtasks.values()) {
-    console.log(
-      chalk.bold(`Running the subtask "${formatTaskId(subtask.id)}"`),
-    );
     await subtask.run({ noCompile: true });
     console.log();
   }
 
-  if (process.exitCode !== 0) {
+  if (process.exitCode !== undefined && process.exitCode !== 0) {
     console.error("Test run failed");
   }
 };