Skip to content

Commit

Permalink
test: re-enable ws test (#4842)
Browse files Browse the repository at this point in the history
  • Loading branch information
fvictorio authored Feb 12, 2024
1 parent d19373a commit f0f5ca6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -650,9 +650,11 @@ export class EdrProviderWrapper

private _ethEventListener(event: SubscriptionEvent) {
const subscription = `0x${event.filterId.toString(16)}`;
const result = event.result;
this._emitLegacySubscriptionEvent(subscription, result);
this._emitEip1193SubscriptionEvent(subscription, result);
const results = Array.isArray(event.result) ? event.result : [event.result];
for (const result of results) {
this._emitLegacySubscriptionEvent(subscription, result);
this._emitEip1193SubscriptionEvent(subscription, result);
}
}

private _emitLegacySubscriptionEvent(subscription: string, result: any) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,7 @@ describe("Eth module", function () {
return onPending;
});

// TODO: https://github.com/NomicFoundation/edr/issues/279
it.skip("contract events work", async function () {
it("contract events work", async function () {
const signer = await provider.getSigner();
const Factory = new ethers.ContractFactory<[], ethers.Contract>(
EXAMPLE_CONTRACT.abi,
Expand Down

0 comments on commit f0f5ca6

Please sign in to comment.