Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in compilation when multiple versions are used with many contracts #4490

Closed
fvictorio opened this issue Oct 17, 2023 · 0 comments · Fixed by #4550
Closed

Bug in compilation when multiple versions are used with many contracts #4490

fvictorio opened this issue Oct 17, 2023 · 0 comments · Fixed by #4550
Assignees
@ChristopherDedominici
Labels
area:compilation Related to the built-in compile task status:ready This issue is ready to be worked on type:bug Something isn't working

Comments

@fvictorio
Copy link
Member

fvictorio commented Oct 17, 2023 •
edited
Loading

See original discussion here: #3722

Reproduction:

  1. Clone the chainlink repo (I used commit f74c15a717)
  2. cd contracts && pnpm i
  3. Remove the TypeChain plugin from the config because it messes with hh clean --global
  4. Run while true; do hh clean && hh clean --global && hh compile || break; done. This will remove the downloaded compilers and re-compile the project until it fails.

This seems to be fixed by #3818
@fvictorio fvictorio added type:bug Something isn't working area:compilation Related to the built-in compile task labels Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Oct 17, 2023
@fvictorio fvictorio moved this from Backlog to To-do in Hardhat Oct 17, 2023
@fvictorio fvictorio removed the status in Hardhat Oct 17, 2023
@fvictorio fvictorio moved this to To-do in Hardhat Oct 17, 2023
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 17, 2023
@fvictorio fvictorio mentioned this issue Oct 17, 2023
Closed
@fvictorio fvictorio moved this from To-do to In Progress in Hardhat Nov 1, 2023
@ChristopherDedominici ChristopherDedominici linked a pull request Nov 1, 2023 that will close this issue
Bug in compilation when multiple versions are used with many contracts #4550
Merged
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat Nov 7, 2023
@tmigone tmigone mentioned this issue Dec 22, 2023
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
area:compilation Related to the built-in compile task status:ready This issue is ready to be worked on type:bug Something isn't working
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug in compilation when multiple versions are used with many contracts NomicFoundation/hardhat
2 participants
@fvictorio @ChristopherDedominici