Bug in compilation when multiple versions are used with many contracts #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d211ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…used-with-many-contracts' of github.com:NomicFoundation/hardhat into bug/4490-bug-in-compilation-when-multiple-versions-are-used-with-many-contracts
schaable
reviewed
Nov 3, 2023
| // Since only one process at a time can acquire the mutex, we avoid the risk of downloading the same compiler multiple times. | ||
| // This is because the mutex blocks access until a compiler has been fully downloaded, preventing any new process | ||
| // from checking whether that version of the compiler exists. Without mutex it might incorrectly | ||
| // return false, indicating that the compiler isn't present, even though it is currently being downloaded. |
schaable
approved these changes
Nov 3, 2023
fvictorio
approved these changes
Nov 6, 2023
ChristopherDedominici
deleted the
bug/4490-bug-in-compilation-when-multiple-versions-are-used-with-many-contracts
branch
Closed
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #4490
PROBLEM
If multiple requests to download the same version of a compiler are sent, the download occurs multiple times.
SOLUTION
Modify the existing mutex logic to check if a compiler of a specific version has already been downloaded or is currently being downloaded.