feat: allow configuring max initcode size #4452

agostbiro · 2023-10-06T15:55:23Z

Follow up from #4448 for NomicFoundation/edr#103

changeset-bot · 2023-10-06T15:55:26Z

⚠️ No Changeset found

Latest commit: ea94c58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-10-06T15:55:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 11:11am
hardhat-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 11:11am

agostbiro · 2023-10-06T15:56:39Z

crates/rethnet_eth/Cargo.toml

@@ -20,7 +20,7 @@ reqwest = { version = "0.11", features = ["blocking", "json"] }
 # https://github.com/TrueLayer/reqwest-middleware/blob/main/reqwest-retry/CHANGELOG.md#unreleased
 reqwest-middleware = { git = "https://github.com/TrueLayer/reqwest-middleware", rev = "a54319a", default-features = false }
 reqwest-retry = { git = "https://github.com/TrueLayer/reqwest-middleware", rev = "a54319a", default-features = false }
-revm-primitives = { git = "https://github.com/Wodann/revm", rev = "b6f8ebf", version = "1.1", default-features = false }
+revm-primitives = { git = "https://github.com/agostbiro/revm", rev = "430502e", version = "1.1", default-features = false }


will need to change to Wodann/revm once the PR is merged

agostbiro · 2023-10-06T15:56:46Z

crates/rethnet_evm/Cargo.toml

@@ -21,7 +21,7 @@ once_cell = { version = "1.18.0", default-features = false, features = ["alloc",
 parking_lot = { version = "0.12.1", default-features = false }
 rethnet_defaults = { version = "0.1.0-dev", path = "../rethnet_defaults" }
 rethnet_eth = { version = "0.1.0-dev", path = "../rethnet_eth", features = ["serde"] }
-revm = { git = "https://github.com/Wodann/revm", rev = "b6f8ebf", version = "3.3", default-features = false, features = ["dev", "secp256k1", "serde", "std"] }
+revm = { git = "https://github.com/agostbiro/revm", rev = "430502e", version = "3.3", default-features = false, features = ["dev", "secp256k1", "serde", "std"] }


will need to change to Wodann/revm once the PR is merged

crates/rethnet_eth/Cargo.toml

crates/rethnet_evm/Cargo.toml

Wodann · 2023-10-06T16:03:26Z

crates/rethnet_evm_napi/src/config.rs

        cfg.disable_block_gas_limit = disable_block_gas_limit;
        cfg.disable_eip3607 = disable_eip3607;

        Ok(cfg)
    }
 }
+
+fn bigint_to_usize(value: BigInt) -> Result<Option<usize>, napi::Error> {
+    if let (false, size, true) = value.get_u64() {


This is legacy. For newer code, I've been using foo: u64 = BigInt::try_cast(value)

Done in 9a40d57

Wodann · 2023-10-06T16:04:29Z

crates/rethnet_eth/Cargo.toml

@@ -20,7 +20,7 @@ reqwest = { version = "0.11", features = ["blocking", "json"] }
 # https://github.com/TrueLayer/reqwest-middleware/blob/main/reqwest-retry/CHANGELOG.md#unreleased
 reqwest-middleware = { git = "https://github.com/TrueLayer/reqwest-middleware", rev = "a54319a", default-features = false }
 reqwest-retry = { git = "https://github.com/TrueLayer/reqwest-middleware", rev = "a54319a", default-features = false }
-revm-primitives = { git = "https://github.com/Wodann/revm", rev = "b6f8ebf", version = "1.1", default-features = false }
+revm-primitives = { git = "https://github.com/Wodann/revm", rev = "4cf16b8", version = "1.1", default-features = false }


I merged the other PR and updated. The Cargo.lock changes might have to be updated as well though, @agostbiro

Done in 7229668

Updated to latest 0fc3c48

crates/rethnet_evm_napi/src/config.rs

feat: allow configuring max initcode size

304a3d8

agostbiro added the area:edr label Oct 6, 2023

agostbiro self-assigned this Oct 6, 2023

github-actions bot added the status:triaging label Oct 6, 2023

vercel bot deployed to Preview – hardhat-storybook October 6, 2023 15:55 View deployment

agostbiro requested a review from Wodann October 6, 2023 15:55

agostbiro commented Oct 6, 2023

View reviewed changes

vercel bot deployed to Preview – hardhat October 6, 2023 15:56 View deployment

Wodann reviewed Oct 6, 2023

View reviewed changes

crates/rethnet_eth/Cargo.toml Outdated Show resolved Hide resolved

Wodann reviewed Oct 6, 2023

View reviewed changes

crates/rethnet_evm/Cargo.toml Outdated Show resolved Hide resolved

misc: change revm-primitives revision

d27b3df

vercel bot deployed to Preview – hardhat-storybook October 6, 2023 16:04 View deployment

vercel bot deployed to Preview – hardhat October 6, 2023 16:05 View deployment

Wodann requested changes Oct 6, 2023

View reviewed changes

Wodann temporarily deployed to edr-release October 6, 2023 16:29 — with GitHub Actions Inactive

agostbiro added 2 commits October 9, 2023 10:36

Change REVM to Wodann/revm

7229668

Use TryCast for usize conversion

9a40d57

vercel bot deployed to Preview – hardhat-storybook October 9, 2023 08:38 View deployment

vercel bot deployed to Preview – hardhat October 9, 2023 08:38 View deployment

agostbiro temporarily deployed to edr-release October 9, 2023 09:03 — with GitHub Actions Inactive

Update REVM version

0fc3c48

vercel bot deployed to Preview – hardhat-storybook October 9, 2023 16:18 View deployment

agostbiro requested a review from Wodann October 9, 2023 16:18

vercel bot deployed to Preview – hardhat October 9, 2023 16:18 View deployment

agostbiro temporarily deployed to edr-release October 9, 2023 16:38 — with GitHub Actions Inactive

Wodann requested changes Oct 9, 2023

View reviewed changes

crates/rethnet_evm_napi/src/config.rs Outdated Show resolved Hide resolved

Refactor try cast and option

ea94c58

agostbiro temporarily deployed to edr-release October 10, 2023 11:03 — with GitHub Actions Inactive

vercel bot deployed to Preview – hardhat-storybook October 10, 2023 11:10 View deployment

vercel bot deployed to Preview – hardhat October 10, 2023 11:11 View deployment

Wodann approved these changes Oct 10, 2023

View reviewed changes

Wodann merged commit 64ae212 into rethnet/main Oct 10, 2023
75 of 77 checks passed

Wodann deleted the rethnet/max-initcode-size-config branch October 10, 2023 20:07

github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow configuring max initcode size #4452

feat: allow configuring max initcode size #4452

agostbiro commented Oct 6, 2023 •

edited

Loading

changeset-bot bot commented Oct 6, 2023 •

edited

Loading

vercel bot commented Oct 6, 2023 •

edited

Loading

agostbiro Oct 6, 2023

agostbiro Oct 6, 2023

Wodann Oct 6, 2023

agostbiro Oct 9, 2023

Wodann Oct 6, 2023

agostbiro Oct 9, 2023 •

edited

Loading

agostbiro Oct 9, 2023

feat: allow configuring max initcode size #4452

feat: allow configuring max initcode size #4452

Conversation

agostbiro commented Oct 6, 2023 • edited Loading

changeset-bot bot commented Oct 6, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Oct 6, 2023 • edited Loading

agostbiro Oct 6, 2023

Choose a reason for hiding this comment

agostbiro Oct 6, 2023

Choose a reason for hiding this comment

Wodann Oct 6, 2023

Choose a reason for hiding this comment

agostbiro Oct 9, 2023

Choose a reason for hiding this comment

Wodann Oct 6, 2023

Choose a reason for hiding this comment

agostbiro Oct 9, 2023 • edited Loading

Choose a reason for hiding this comment

agostbiro Oct 9, 2023

Choose a reason for hiding this comment

agostbiro commented Oct 6, 2023 •

edited

Loading

changeset-bot bot commented Oct 6, 2023 •

edited

Loading

vercel bot commented Oct 6, 2023 •

edited

Loading

agostbiro Oct 9, 2023 •

edited

Loading