Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Hardhat Ignition's docs #4459

Merged
merged 125 commits into from
Oct 23, 2023
Merged

Import Hardhat Ignition's docs #4459

merged 125 commits into from
Oct 23, 2023

Conversation

alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented Oct 9, 2023 •
edited
Loading

WIP PR

TODO

  • Add ignition to the tools menu in the nav bar
  • Add ignition to the docs landing page
  • Revert navbar change
  • Change the URLs from /hardhat-igniton to /ignition
  • Update all the "other components" sections
  • Review all the docs and write any missing content
  • Define a structure for the docs
  • Update the hardhat tutorial's deployment section
  • Add overview section
  • Double check the navigation order makes sense (the top down order matches the flow of the docs)

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: bfe5d0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 9:25pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 9:25pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 9, 2023
@alcuadrado alcuadrado added the no changeset needed This PR doesn't require a changeset label Oct 9, 2023
@kanej
docs(ignition): update getting-started
720f568 
This is a set of small fixes (no major restructurings) that:

* refer to Hardhat Ignition rather than just Ignition
* Simplify the LockModule code
* Reword multiple phrases
@kanej
docs(ignition): update explanation
8fc1e63 
No major restructurings. Just cleanup of text.
@alcuadrado alcuadrado merged commit e3aa610 into main Oct 23, 2023
4 checks passed
@alcuadrado alcuadrado deleted the ignition-docs branch October 23, 2023 16:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcuadrado @kanej @fzeoli