Fix hardhat-ledger to work with hardhat console #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f60cc9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
area
changed the title
fvictorio
approved these changes
Feb 8, 2024
|
Great catch, thanks! I had no idea that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to use
npx hardhat consolein conjunction withhardhat-ledger. When doing so, after sending any transaction,hardhat consoleexits. This behaviour is related, either unintentionally or not, to the default value ofdiscardStdin. This PR changes the value used.There is a slight behavioral change in the console, which is that, as you might expect, keyboard input while the spinner is running is not discarded. This feels more acceptable than exiting after every transaction.
It does not seem to me that additional tests are required here, but open to guidance on that front.