fix: handle unknown selector error #4811
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crates/edr_provider/src/error.rs
Outdated
| _ => unreachable!( | ||
| "Since we are not validating, no other error can occur: {decode_error:?}" | ||
| ), |
There was a problem hiding this comment.
@agostbiro you're more familiar with this code. Can we logically rule out that none of the other error variants can occur?
There was a problem hiding this comment.
Based on my prior reading of the code for alloy_sol_types::GenericContractError::abi_decode when the validate argument is false, only alloy_sol_types::Error::TypeCheckFail error occurs, but the code is pretty complex and apparently alloy_sol_types::Error::UnknownSelector can occur as well. So it's probably safer to add a fallback where we just convert the error to string.
crates/edr_provider/src/error.rs
Outdated
| _ => unreachable!( | ||
| "Since we are not validating, no other error can occur: {decode_error:?}" | ||
| ), |
There was a problem hiding this comment.
Based on my prior reading of the code for alloy_sol_types::GenericContractError::abi_decode when the validate argument is false, only alloy_sol_types::Error::TypeCheckFail error occurs, but the code is pretty complex and apparently alloy_sol_types::Error::UnknownSelector can occur as well. So it's probably safer to add a fallback where we just convert the error to string.
Fixes NomicFoundation/edr#281