Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache block contexts #4815

Merged
merged 9 commits into from
Feb 13, 2024
Merged

fix: cache block contexts #4815

merged 9 commits into from
Feb 13, 2024

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Feb 2, 2024 •
edited
Loading

Avoid recomputing states by caching them for later use.

This change brings a 100x improvement on the Rocketpool scenario that makes heavy use of snapshots.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fa34d1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro self-assigned this Feb 2, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 3:12pm

@agostbiro agostbiro marked this pull request as draft February 2, 2024 17:20
@Wodann
Copy link
Member

Wodann commented Feb 3, 2024 •
edited
Loading

See proposed changes in #4819 to fix the tests

@Wodann Wodann force-pushed the edr/fix/cache-block-contexts branch from 4468e7d to ab8fb12 Compare February 12, 2024 16:10
@Wodann Wodann force-pushed the edr/fix/cache-block-contexts branch from d07a0b5 to 191062d Compare February 12, 2024 22:51
@Wodann Wodann force-pushed the edr/fix/cache-block-contexts branch from 191062d to 954c6a6 Compare February 12, 2024 23:10
@agostbiro agostbiro marked this pull request as ready for review February 13, 2024 12:04
@agostbiro agostbiro requested a review from Wodann February 13, 2024 12:04
@Wodann Wodann force-pushed the edr/fix/cache-block-contexts branch from e842f51 to fa34d1a Compare February 13, 2024 15:11
@Wodann Wodann merged commit 44da532 into edr/main Feb 13, 2024
69 of 70 checks passed
@Wodann Wodann deleted the edr/fix/cache-block-contexts branch February 13, 2024 15:12
@agostbiro agostbiro mentioned this pull request Feb 13, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@agostbiro agostbiro

@Wodann Wodann

Labels
area:edr
Projects
EDR
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agostbiro @Wodann