Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ARITHMETIC_UNDER_OR_OVERFLOW and mark as deprecated #4837

Closed
wants to merge 1 commit into from
Closed

Restore ARITHMETIC_UNDER_OR_OVERFLOW and mark as deprecated #4837

wants to merge 1 commit into from

Conversation

tamtamchik
Copy link

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.

The silent deletion of ARITHMETIC_UNDER_OR_OVERFLOW in #4755 is causing a breakdown in test logic. As per the documentation, these codes can be used with the .revertedWithPanic matcher. However, this matcher is also designed to accept undefined values, which silently take any panic code. This leads to the test case expectation being spoiled.

So as not to spoil tests that users might already rely on, it's safer to keep the ARITHMETIC_UNDER_OR_OVERFLOW option until the next major release.

Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 257d86f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 2:43pm

@tamtamchik
Copy link
Author

cc @fvictorio can you please review this?

@tamtamchik tamtamchik closed this by deleting the head repository Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant