Restore ARITHMETIC_UNDER_OR_OVERFLOW and mark as deprecated #4837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The silent deletion of ARITHMETIC_UNDER_OR_OVERFLOW in #4755 is causing a breakdown in test logic. As per the documentation, these codes can be used with the
.revertedWithPanic
matcher. However, this matcher is also designed to accept undefined values, which silently take any panic code. This leads to the test case expectation being spoiled.So as not to spoil tests that users might already rely on, it's safer to keep the
ARITHMETIC_UNDER_OR_OVERFLOW
option until the next major release.