Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better different hardfork forking tests #4854

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Better different hardfork forking tests #4854

merged 3 commits into from
Feb 13, 2024

Conversation

fvictorio
Copy link
Member

Depends on #4843

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 06aaa58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 10:54am

@fvictorio fvictorio changed the base branch from cancun to add-parentBeaconBlockRoot-and-blob-properties February 13, 2024 10:53
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 13, 2024
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Feb 13, 2024
schaable
schaable reviewed Feb 13, 2024
View reviewed changes
packages/hardhat-core/src/internal/hardhat-network/provider/node.ts
// we remove them from the block
if (
!this.isCancunBlock(blockNumberOrPending) &&
blockContext.header.blobGasUsed !== undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is blobGasUsed always available in blocks? shouldn't we use parentBeaconBlockRoot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that either three three fields are present, or none is.

@fvictorio fvictorio merged commit cf22ac8 into add-parentBeaconBlockRoot-and-blob-properties Feb 13, 2024
89 checks passed
@fvictorio fvictorio deleted the better-different-hardfork-forking-tests branch February 13, 2024 16:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable left review comments

@ChristopherDedominici ChristopherDedominici ChristopherDedominici approved these changes

Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvictorio @schaable @ChristopherDedominici