Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setStorageAt in untouched addresses #4864

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

fvictorio
Copy link
Member

The latest version of ethereumjs fails if you modify the storage of an account that doesn't exist yet. This only happens for setStorageAt but I added tests for the other setters too (nonce, balance and code).

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 28c47fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 9:28am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 15, 2024
@alcuadrado
Copy link
Member

Can we report this and any other issue we find to ethereumjs?

@schaable schaable merged commit 57d2250 into main Feb 15, 2024
93 checks passed
@schaable schaable deleted the storage-at-untouched-addresses branch February 15, 2024 12:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants