Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatibility for community modules using EthereumJS' VM #4894

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

fvictorio
Copy link
Member

@fvictorio fvictorio commented Feb 20, 2024

See 4b1d60f for the details.

I tested this locally with a couple of projects and it seems to work fine.

Add a _node property to the provider, which in turn has a _vm
property with an object that works as a partial implementation of
ethereumjs vm we used to have. More specifically: it supports
evm events and some statemanager methods.

We are doing this to prevent plugins like solidity-coverage from
breaking with the EDR refactor.
Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: 4b1d60f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 11:12am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 20, 2024
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Feb 20, 2024
@Wodann Wodann added area:edr and removed no changeset needed This PR doesn't require a changeset labels Feb 21, 2024
@Wodann Wodann linked an issue Feb 21, 2024 that may be closed by this pull request
@Wodann Wodann changed the title Make solidity-coverage work with EDR feat: add backwards compatibility for community modules using EthereumJS' VM Feb 21, 2024
@Wodann Wodann changed the title feat: add backwards compatibility for community modules using EthereumJS' VM feat: add compatibility for community modules using EthereumJS' VM Feb 21, 2024
@Wodann Wodann merged commit a5d58a1 into main Feb 21, 2024
95 of 105 checks passed
@Wodann Wodann deleted the edr/support-solidity-coverage branch February 21, 2024 00:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:edr status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Hardhat to expose EDR to community modules
3 participants