Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported Node versions: drop support for Node 16 #4898

Closed
wants to merge 6 commits into from
Closed

Update supported Node versions: drop support for Node 16 #4898

wants to merge 6 commits into from

Conversation

ChristopherDedominici
Copy link
Contributor

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2359641

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 9:27am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 20, 2024
@ChristopherDedominici ChristopherDedominici linked an issue Feb 21, 2024 that may be closed by this pull request
Update supported Node versions: drop support for Node 16 #4886
Closed
schaable
schaable reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristopherDedominici I think you're missing the github workflows and the .devcontainer file

@ChristopherDedominici
Copy link
Contributor Author

ChristopherDedominici commented Feb 23, 2024 •
edited
Loading

@ChristopherDedominici I think you're missing the github workflows and the .devcontainer file

@schaable they are already set to support node 18

@ChristopherDedominici ChristopherDedominici marked this pull request as ready for review February 26, 2024 10:43
@fvictorio fvictorio mentioned this pull request Mar 1, 2024
Merged
@fvictorio
Copy link
Member

Closing in favor of #4948.

When merging main into this branch, I get a lot of unrelated changes, and there's this lockfile conflict. @ChristopherDedominici maybe you branched off from ethereumjs/main?

@fvictorio fvictorio closed this Mar 1, 2024
@fvictorio fvictorio deleted the feature/drop-support-for-node-16 branch March 7, 2024 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

@kanej kanej Awaiting requested review from kanej

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supported Node versions: drop support for Node 16
3 participants
@ChristopherDedominici @fvictorio @schaable