Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support hex string in eth_signTypedData_v4 salt #5033

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

agostbiro
Copy link
Member

Adds workaround for NomicFoundation/edr#346

@agostbiro agostbiro requested review from fvictorio and Wodann March 27, 2024 12:07
@agostbiro agostbiro self-assigned this Mar 27, 2024
Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: c42bd63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 0:14am

@agostbiro agostbiro had a problem deploying to github-action-benchmark March 27, 2024 12:07 — with GitHub Actions Error
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Mar 27, 2024
@agostbiro agostbiro had a problem deploying to github-action-benchmark March 27, 2024 14:02 — with GitHub Actions Failure
@agostbiro
Copy link
Member Author

agostbiro commented Mar 27, 2024

It's ok to merge despite the performance regression alert since this PR only changed eth_signTypedData_v4 and the reported regression was for the synthetix scenario which doesn't include this RPC call.

@agostbiro
Copy link
Member Author

Hardhat e2ee tests will continue to hang until latest version of EDR is released, so it's safe to ignore.

@agostbiro agostbiro merged commit 60b2a62 into main Mar 27, 2024
39 of 43 checks passed
@agostbiro agostbiro deleted the edr/fix/typed-data-hex-string-salt branch March 27, 2024 16:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:edr status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants