Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce hardhat-node-test-reporter's integration tests flakiness #5779

Merged
merged 3 commits into from
Oct 7, 2024
Merged

test: reduce hardhat-node-test-reporter's integration tests flakiness #5779

merged 3 commits into from
Oct 7, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Sep 26, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

I propose that we remove the slow tests markings from the test reporter's integration tests altogether as they can cause flakiness because of system load.

@galargh galargh requested a review from schaable September 26, 2024 13:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2f152ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Sep 26, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 10:55am

@galargh galargh marked this pull request as draft September 26, 2024 14:55
@galargh
Copy link
Member Author

galargh commented Sep 26, 2024

I need to handle color codes around slow test indicators properly. Moving this to draft until that's completed.

@galargh galargh force-pushed the galargh/reporter-flakiness branch from fb56a4c to 97553ba Compare October 7, 2024 10:45
@galargh galargh marked this pull request as ready for review October 7, 2024 10:46
@galargh galargh added this pull request to the merge queue Oct 7, 2024
@galargh galargh removed this pull request from the merge queue due to a manual request Oct 7, 2024
@galargh galargh force-pushed the galargh/reporter-flakiness branch from 97553ba to 2f152ea Compare October 7, 2024 10:54
@galargh galargh enabled auto-merge October 7, 2024 10:55
@galargh galargh added this pull request to the merge queue Oct 7, 2024
Merged via the queue into v-next with commit b32a843 Oct 7, 2024
74 checks passed
@galargh galargh deleted the galargh/reporter-flakiness branch October 7, 2024 11:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

@schaable schaable Awaiting requested review from schaable

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galargh @alcuadrado