Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm noticing some errors in our CI that look something like:
My first hunch would be that it's something connected to the stdout stream, but honestly, I'm not sure.
First, I'll try to check whether this could be caused by our custom node test reporter by running the hardhat tests both with and without it many times and seeing what happens. We'll take it from there.
It is not because of our reporter. Here's the same error from the default reporter:
What's interesting here is that we start displaying the hardhat welcome message and then the error happens. This suggests it could be in fact related to writing to the
stdout
from the tests. Next, I'll try to give the init an alternative stream to write to during the tests and trying to run the command many times to see if the issue persists.Looks like disabling
console.log
does the trick. I'm going to close this now and implement that "fix" in a new PR.