-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace spec with a custom hardhat solidity test reporter #5809
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
0d2a959
to
4853c49
Compare
4853c49
to
879d57b
Compare
879d57b
to
bf74e02
Compare
bf74e02
to
e0626ad
Compare
e0626ad
to
08e7069
Compare
08e7069
to
096b016
Compare
096b016
to
1923831
Compare
import type { SuiteResult } from "@ignored/edr"; | ||
import type { Readable } from "node:stream"; | ||
|
||
export type TestStatus = "Success" | "Failure" | "Skipped"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think EDR changed how they export enums now, so this can probably be improved in a later PR, so that we avoid the duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting Cannot access ambient const enums when 'isolatedModules' is enabled.ts(2748)
when trying to use the TestStatus
enum from edr. Should I report that to the team?
This PR introduces a custom hardhat solidity test reporter in place of the spec reporter that we used to use.
It is an implementation of the design outline in https://www.notion.so/nomicfoundation/Runner-Reporter-Design-11f578cdeaf580b8b01ddc43ae589f05
This PR doesn't change the output formatting.
Testing
The runner/reporter setup have been tested manually. It would be great to introduce a more formalised E2E testing for the solidity testing task, but it is left as a follow-up for now.