Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace spec with a custom hardhat solidity test reporter #5809

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Oct 8, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR introduces a custom hardhat solidity test reporter in place of the spec reporter that we used to use.

It is an implementation of the design outline in https://www.notion.so/nomicfoundation/Runner-Reporter-Design-11f578cdeaf580b8b01ddc43ae589f05

This PR doesn't change the output formatting.

Testing

The runner/reporter setup have been tested manually. It would be great to introduce a more formalised E2E testing for the solidity testing task, but it is left as a follow-up for now.

@galargh galargh requested a review from kanej October 8, 2024 10:14
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 4:13pm

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 1923831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

import type { SuiteResult } from "@ignored/edr";
import type { Readable } from "node:stream";

export type TestStatus = "Success" | "Failure" | "Skipped";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EDR changed how they export enums now, so this can probably be improved in a later PR, so that we avoid the duplication.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting Cannot access ambient const enums when 'isolatedModules' is enabled.ts(2748) when trying to use the TestStatus enum from edr. Should I report that to the team?

@galargh galargh added this pull request to the merge queue Oct 24, 2024
Merged via the queue into v-next with commit 50f5b96 Oct 24, 2024
64 checks passed
@galargh galargh deleted the feat/solidity-test-reporter branch October 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants