Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardhat-utils return type improvements #5812

Merged
merged 9 commits into from
Oct 21, 2024
Merged

hardhat-utils return type improvements #5812

merged 9 commits into from
Oct 21, 2024

Conversation

schaable
Copy link
Member

@schaable schaable commented Oct 9, 2024 •
edited
Loading

This PR improves the return types of the eth, hex and number modules. It also renames the isHexStringPrefixed function to isPrefixedHexString for consistency and to follow adjective-noun order.

EDIT: Also removed async from toBigInt function.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9a87ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:15pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 9, 2024
alcuadrado
alcuadrado reviewed Oct 10, 2024
View reviewed changes
v-next/hardhat-utils/src/eth.ts Outdated
@@ -1,19 +1,61 @@
import type { PrefixedHexString } from "./hex.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is starting to have many unrelated things. Maybe we should split it into multiple ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the library linking logic from this PR and will submit it in a follow-up PR.

@schaable schaable force-pushed the hh-utils-improvements branch from b4a965e to 697e116 Compare October 11, 2024 14:31
@schaable schaable force-pushed the hh-utils-improvements branch from 697e116 to 9a11fe8 Compare October 11, 2024 14:32
@schaable schaable changed the title hardhat-utils improvements hardhat-utils return type improvements Oct 11, 2024
@schaable schaable requested a review from alcuadrado October 11, 2024 14:37
@schaable schaable force-pushed the hh-utils-improvements branch from 2d9551c to 1a8ca51 Compare October 21, 2024 16:03
kanej
kanej approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schaable schaable added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@schaable schaable added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@kanej kanej enabled auto-merge October 21, 2024 17:14
@kanej kanej added this pull request to the merge queue Oct 21, 2024
Merged via the queue into v-next with commit 6f55402 Oct 21, 2024
69 checks passed
@kanej kanej deleted the hh-utils-improvements branch October 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

@ChristopherDedominici ChristopherDedominici Awaiting requested review from ChristopherDedominici

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaable @kanej @alcuadrado