Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build assert #5856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor build assert #5856

wants to merge 1 commit into from

Conversation

RenanSouza2
Copy link
Contributor

This Pr improves code readability in the build assert file,

[X] tests passing
[X] lint:fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e3ad28c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:08pm

@RenanSouza2
Copy link
Contributor Author

Code readability can be very subjective but I would like to discuss this change if possible

@kanej kanej force-pushed the refactor-build-assert branch from 6edfec3 to e3ad28c Compare November 22, 2024 16:06
@kanej kanej added no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on and removed status:triaging labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kanej kanej

Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Hardhat
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenanSouza2 @kanej