Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await output streams #5871

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Await output streams #5871

merged 4 commits into from
Oct 28, 2024

Conversation

alcuadrado
Copy link
Member

This PR fixes a race condition that we had when piping readable streams into stdout.

It introduces a utility that creates a Writable based on another Writable, which "pipes" everything to the latter, but without closing it.

This allows us to pipe readable into a writable and await for all the writes to complete.

@alcuadrado alcuadrado requested a review from galargh October 28, 2024 20:10
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:31pm

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 742556b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 28, 2024
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Oct 28, 2024
@alcuadrado alcuadrado merged commit 9786e45 into v-next Oct 28, 2024
70 checks passed
@alcuadrado alcuadrado deleted the output-streams branch October 28, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant