Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat-network-helpers: TODOs as soon as V3 node is ready #5882

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Hardhat-network-helpers: TODOs as soon as V3 node is ready #5882

merged 12 commits into from
Oct 29, 2024

Conversation

ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Oct 29, 2024 •
edited
Loading

This PR implements the TODOs in this issue.

All of them are addressed except for the allow-blocks-same-timestamp because that feature is not implemented yet in V3.

IN SHORT:
This PR enables tests that were previously skipped due to V3 lacking a node. With the node now available, these tests can be executed.

@ChristopherDedominici ChristopherDedominici added the no changeset needed This PR doesn't require a changeset label Oct 29, 2024
@ChristopherDedominici ChristopherDedominici self-assigned this Oct 29, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 4:47pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 261ed53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChristopherDedominici ChristopherDedominici linked an issue Oct 29, 2024 that may be closed by this pull request
Hardhat-network-helpers: TODOs as soon as V3 node is ready #5757
Closed
6 tasks
@ChristopherDedominici ChristopherDedominici mentioned this pull request Oct 29, 2024
Closed
6 tasks
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Oct 29, 2024
@ChristopherDedominici ChristopherDedominici added this pull request to the merge queue Oct 29, 2024
Merged via the queue into v-next with commit 53dc7fa Oct 29, 2024
15 checks passed
@ChristopherDedominici ChristopherDedominici deleted the use-v3-node-in-hh-network-helpers branch October 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

@kanej kanej Awaiting requested review from kanej

Assignees

@kanej kanej

@ChristopherDedominici ChristopherDedominici

Labels
no changeset needed This PR doesn't require a changeset status:triaging v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardhat-network-helpers: TODOs as soon as V3 node is ready
3 participants
@ChristopherDedominici @alcuadrado @kanej