Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds --output to flatten #5947

Merged

Conversation

s-di-cola
Copy link
Contributor

  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.

Implements --output parameter for flatten task as requested in #3430. This allows users to specify an output file path for the flattened contract, improving usability especially on Windows systems where shell redirection may not work consistently.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:48am

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: f7c461a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio
Copy link
Member

This looks good, but I'll let someone from the Hardhat team actually review it in depth and approve it. This also needs a changeset, of course.

@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Nov 22, 2024
@kanej kanej requested a review from galargh November 22, 2024 16:24
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks for the contribution! I'll wait for the CI to pass and merge 🥇

@galargh galargh merged commit 9ad82f5 into NomicFoundation:main Nov 28, 2024
105 checks passed
Copy link

gitpoap-bot bot commented Nov 28, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants