Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate abort during telemetry consent enquiry #5966

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Nov 21, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Resolves #5963

This PR adds more logging around telemetry consent retrieval that I found useful when debugging this issue.

It also addresses the issue itself by removing the catch block from the confirmation prompt. Before, reaching the timeout and aborting during the prompt would lead to the same result - undefined. Now, if a user aborts the prompt, the error that this produces will be propagated up as expected.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 334a6b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:07am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 21, 2024
@galargh galargh added this pull request to the merge queue Nov 22, 2024
Merged via the queue into v-next with commit fd3b0cc Nov 22, 2024
48 checks passed
@galargh galargh deleted the consent-abort branch November 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants