fix: propagate abort during telemetry consent enquiry #5966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5963
This PR adds more logging around telemetry consent retrieval that I found useful when debugging this issue.
It also addresses the issue itself by removing the catch block from the confirmation prompt. Before, reaching the timeout and aborting during the prompt would lead to the same result -
undefined
. Now, if a user aborts the prompt, the error that this produces will be propagated up as expected.