Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Fix in Linaria Documentation #5968

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

donatik27
Copy link
Contributor

  1. File: docs/src/content/ignition/docs/guides/upgradeable-proxies.md
    Old text: "This file will look a little different than the others"
    New text: "This file will look a little different from the others"
    Reason: Using "different from" is grammatically correct when comparing two things, while "different than" is incorrect in formal technical documentation.

  2. File: docs/README.md
    Old text: "with works fine with SSG sites"
    New text: "which works fine with SSG sites"
    Reason: The word "which" is the correct relative pronoun to connect the clauses and describe the functionality of Linaria's CSS generation. Using "with" was grammatically incorrect and made the sentence unclear.

Old text: "Landing pages contains"
New text: "Landing pages contain"
Reason: Fixed subject-verb agreement since "pages" is plural, the verb should be "contain" not "contains" to maintain proper grammar.

  1. File: docs/src/content/hardhat-runner/docs/config/index.md
    Old text: "where your contract are stored"
    New text: "where your contracts are stored"
    Reason: The word needs to be plural since it refers to multiple smart contracts in the documentation context.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: ed49b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 0:22am

@schaable schaable added the no changeset needed This PR doesn't require a changeset label Nov 21, 2024
@schaable schaable merged commit 97365ef into NomicFoundation:main Nov 21, 2024
10 of 11 checks passed
Copy link

gitpoap-bot bot commented Nov 21, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset status:triaging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants