fix(hardhat-foundry): config clashes condition

[wiasliaw]

• Because this PR includes a bug fix, relevant tests have been included.
• Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• I didn't do anything of this.

---

hardhat/packages/hardhat-foundry/src/index.ts

Lines 69 to 71 in ad3df5b

	if (config.paths.cache === foundryCachePath) {
	config.paths.cache = "cache_hardhat";
	}

The code above is to solve config collision between foundry and hardhat. However, the condition will cause a weird behavior when foundry config is the same as hardhat config.

i.e.

foundry config:

[profile.default]
cache_path = "sample_cache"

hardhat config:

/** @type import('hardhat/config').HardhatUserConfig */
module.exports = {
  paths: {
    cache: path.resolve(__dirname, "sample_cache"),
  }
}

Run hardhat compile and the cache folder will be generated in path {project_root}/cache_hardhat.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8f55685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2024 7:03am

[antico5]

This is the intended behavior, we want to avoid foundry and hardhat using the same directory for cache, so when they are set to be the same, we change hardhat's cache directory to cache_hardhat. Is there a reason why you would want both caches to be on the same directory?

[wiasliaw]

@antico5 sorry for replying late.

afaik, both hardhat and foundry use sloc for compilation. cache files should not be different with the same version of the solc.

[antico5]

There might be cases where both could use the same cache directory without conflict, but it's wise to keep them separated to prevent potential clashes. E.g. you can specify different solc versions on the different frameworks. Also each framework may use the cache directory for other purposes besides just the solc cache and from that perspective it's convenient that they are on separate directories.