Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro-eth-signer issue when deploying local accounts #6017

Merged
merged 5 commits into from
Dec 9, 2024
Merged

micro-eth-signer issue when deploying local accounts #6017

merged 5 commits into from
Dec 9, 2024

Conversation

ChristopherDedominici
Copy link
Contributor

The branch for this PR was checked out from this other PR.

This PR adds logic to handle transactions sent to the null address:

  • Updates the version of micro-eth-signer to handle transactions directed to the null address. See release notes.
  • If both the "to" field and the "data" field are undefined, an error is thrown.
  • If the "to" field is undefined but the "data" field is not, the "to" address is set to "0x", which is the expected address in micro-eth-signer for processing transactions to the null address.

NOTES:

If the "to" field and the "data" field are explicitly set to null, a zod validation error will be thrown.

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 2:15pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8a0b6bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChristopherDedominici ChristopherDedominici added no changeset needed This PR doesn't require a changeset and removed status:triaging labels Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

hardhat

Total size of the bundle: 228M
Total number of dependencies (including transitive): 60

List of dependencies (sorted by size) 
223M	total
30M	@ignored/edr-optimism-linux-x64-musl
30M	@ignored/edr-optimism-linux-x64-gnu
27M	@ignored/edr-optimism-linux-arm64-musl
27M	@ignored/edr-optimism-linux-arm64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-darwin-x64
20M	esbuild
20M	@ignored/edr-optimism-darwin-arm64
8.9M	solc
2.8M	@sentry/tracing
2.4M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@sentry/types
1.2M	@noble/hashes
932K	@sentry/node
920K	@sentry/utils
824K	zod
816K	@ignored/hardhat-vnext-utils
616K	micro-packed
576K	tsx
548K	@sentry/core
504K	fast-equals
492K	@scure/bip39
460K	@ignored/edr
384K	@ignored/edr-optimism
368K	ethereum-cryptography
344K	@sentry/hub
320K	enquirer
284K	semver
284K	@ignored/hardhat-vnext-errors
188K	commander
168K	@scure/base
136K	adm-zip
128K	get-tsconfig
96K	@scure/bip32
92K	chalk
88K	tslib
88K	@sentry/minimal
84K	js-sha3
76K	agent-base
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	lru_map
64K	https-proxy-agent
60K	@ignored/hardhat-vnext-zod-utils
56K	rfdc
56K	follow-redirects
48K	memorystream
48K	command-exists
48K	ansi-colors
44K	tmp
40K	resolve-pkg-maps
36K	p-map
32K	cookie
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	os-tmpdir
20K	ms

@ChristopherDedominici ChristopherDedominici linked an issue Dec 5, 2024 that may be closed by this pull request
micro-eth-signer issue when deploying local accounts #5967
Closed
3 tasks
alcuadrado
alcuadrado reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small comments, but it looks good.

alcuadrado
alcuadrado reviewed Dec 5, 2024
View reviewed changes
v-next/hardhat/src/internal/builtin-plugins/network-manager/rpc/types/address.ts Outdated
@@ -14,6 +14,7 @@ export const rpcAddress: ZodType<Uint8Array> = conditionalUnionType(
z.instanceof(Uint8Array),
],
[isAddress, z.string()],
[(data) => data === null, z.null()],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this also affect from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I allowed the null value only for the "to" field here

Base automatically changed from rework-providers to v-next December 9, 2024 14:16
@ChristopherDedominici ChristopherDedominici added this pull request to the merge queue Dec 9, 2024
Merged via the queue into v-next with commit e484a7a Dec 9, 2024
137 checks passed
@ChristopherDedominici ChristopherDedominici deleted the update-micro-signer branch December 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@ChristopherDedominici ChristopherDedominici

Labels
no changeset needed This PR doesn't require a changeset
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

micro-eth-signer issue when deploying local accounts
3 participants
@ChristopherDedominici @alcuadrado @kanej