feat: port the node task to hardhat v3 #6025

galargh · 2024-12-06T14:54:09Z

Because this PR includes a bug fix, relevant tests have been included.
Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
I didn't do anything of this.

In this PR, I port the node task from v2 to v3. I describe my design choices in https://www.notion.so/nomicfoundation/Node-Task-154578cdeaf5802c870ee4c7ea7a05ba (this doc should be helpful in guiding the review)

Follow-ups

Testing

I successfully started a node using hardhat3 node and deployed a contract from the v2 sample project to it using ignition.
I added a test case in which I start a JSON RPC server from an EDR provider, create an additional HTTP provider pointing at the server, and compare responses to an eth_chainId request. The test suite could definitely be expanded.

changeset-bot · 2024-12-06T14:54:14Z

⚠️ No Changeset found

Latest commit: 5b91fdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-06T14:54:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2024 11:10am

github-actions · 2024-12-06T14:57:18Z

hardhat

Total size of the bundle: 228M
Total number of dependencies (including transitive): 61

List of dependencies (sorted by size)

224M	total
30M	@ignored/edr-optimism-linux-x64-musl
30M	@ignored/edr-optimism-linux-x64-gnu
27M	@ignored/edr-optimism-linux-arm64-musl
27M	@ignored/edr-optimism-linux-arm64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-darwin-x64
20M	esbuild
20M	@ignored/edr-optimism-darwin-arm64
8.9M	solc
2.8M	@sentry/tracing
2.4M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@sentry/types
1.2M	@noble/hashes
932K	@sentry/node
920K	@sentry/utils
856K	zod
816K	@ignored/hardhat-vnext-utils
616K	micro-packed
576K	tsx
548K	@sentry/core
504K	fast-equals
492K	@scure/bip39
460K	@ignored/edr
384K	@ignored/edr-optimism
368K	ethereum-cryptography
344K	@sentry/hub
320K	enquirer
288K	@ignored/hardhat-vnext-errors
284K	semver
192K	ws
188K	commander
168K	@scure/base
136K	adm-zip
128K	get-tsconfig
96K	@scure/bip32
92K	chalk
88K	tslib
88K	@sentry/minimal
84K	js-sha3
76K	agent-base
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	lru_map
64K	https-proxy-agent
60K	@ignored/hardhat-vnext-zod-utils
56K	rfdc
56K	follow-redirects
48K	memorystream
48K	command-exists
48K	ansi-colors
44K	tmp
40K	resolve-pkg-maps
36K	p-map
32K	cookie
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	os-tmpdir
20K	ms

galargh · 2024-12-10T16:21:37Z

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts

This is a direct port of https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-core/src/internal/hardhat-network/jsonrpc/handler.ts

galargh · 2024-12-10T16:22:05Z

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/server.ts

This is a direct port of https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-core/src/internal/hardhat-network/jsonrpc/server.ts

galargh · 2024-12-10T19:45:07Z

@schaable Tagging you for a review, too, as per our initiative to spread the process. https://www.notion.so/nomicfoundation/Node-Task-154578cdeaf5802c870ee4c7ea7a05ba should be helpful for a little more context.

schaable

Hey Piotr! Overall, this looks good, but I’ve left a couple of comments. Feel free to make a decision on the ones marked as minor and consider them resolved.

v-next/hardhat/src/internal/builtin-plugins/network-manager/json-rpc.ts

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/server.ts

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts

schaable · 2024-12-16T16:53:53Z

v-next/hardhat/src/internal/builtin-plugins/node/json-rpc/handler.ts

+      return;
+    }
+
+    if (Array.isArray(jsonHttpRequest)) {


I think we deprecated the sendBatch method in EthereumProvider, so handling multiple requests at once could be unnecessary.

I will add a note about that next to the block for now and try to find out if we plan to add support for batch requests in the future.

galargh · 2024-12-17T11:10:50Z

Thanks @schaable - that was really helpful 🙇 I've tried to address all the comments in 5b91fdb (#6025)

schaable

LGTM!

github-actions bot added the status:ready This issue is ready to be worked on label Dec 6, 2024

galargh force-pushed the feat/v-next-node branch from 8251902 to 7b82df3 Compare December 6, 2024 14:55

vercel bot deployed to Preview December 6, 2024 14:56 View deployment

galargh force-pushed the feat/v-next-node branch from 7b82df3 to b93cf5e Compare December 6, 2024 15:14

vercel bot deployed to Preview December 6, 2024 15:16 View deployment

galargh force-pushed the feat/v-next-node branch from b93cf5e to 2235e4f Compare December 6, 2024 15:17

vercel bot deployed to Preview December 6, 2024 15:18 View deployment

galargh force-pushed the feat/v-next-node branch from 2235e4f to 1bf954a Compare December 6, 2024 15:20

vercel bot deployed to Preview December 6, 2024 15:21 View deployment

galargh force-pushed the feat/v-next-node branch from 1bf954a to 94da3a2 Compare December 6, 2024 15:58

vercel bot deployed to Preview December 6, 2024 16:00 View deployment

galargh force-pushed the feat/v-next-node branch from 94da3a2 to a34b576 Compare December 7, 2024 00:19

vercel bot deployed to Preview December 7, 2024 00:20 View deployment

galargh force-pushed the feat/v-next-node branch from a34b576 to 716ec33 Compare December 10, 2024 14:18

vercel bot deployed to Preview December 10, 2024 14:19 View deployment

galargh force-pushed the feat/v-next-node branch from 716ec33 to 90e3a4d Compare December 10, 2024 16:17

vercel bot deployed to Preview December 10, 2024 16:19 View deployment

galargh commented Dec 10, 2024

View reviewed changes

feat: port the node task to hardhat v3

7f9a2c4

galargh force-pushed the feat/v-next-node branch from 90e3a4d to 7f9a2c4 Compare December 10, 2024 16:28

galargh changed the title ~~[WIP - not ready for review] feat: port the node task to hardhat v3~~ feat: port the node task to hardhat v3 Dec 10, 2024

vercel bot deployed to Preview December 10, 2024 16:29 View deployment

galargh marked this pull request as ready for review December 10, 2024 16:50

galargh requested review from alcuadrado and schaable December 10, 2024 19:43

schaable reviewed Dec 16, 2024

View reviewed changes

galargh added 2 commits December 17, 2024 11:32

Merge remote-tracking branch 'origin/v-next' into feat/v-next-node

7603dd7

chore: apply the review suggestions

5b91fdb

vercel bot deployed to Preview December 17, 2024 11:10 View deployment

galargh requested a review from schaable December 17, 2024 11:10

schaable approved these changes Dec 17, 2024

View reviewed changes

galargh added this pull request to the merge queue Dec 18, 2024

Merged via the queue into v-next with commit 4aade7e Dec 18, 2024
137 checks passed

galargh deleted the feat/v-next-node branch December 18, 2024 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: port the node task to hardhat v3 #6025

feat: port the node task to hardhat v3 #6025

galargh commented Dec 6, 2024 •

edited

Loading

changeset-bot bot commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024 •

edited

Loading

galargh Dec 10, 2024

galargh Dec 10, 2024

galargh commented Dec 10, 2024

schaable left a comment

schaable Dec 16, 2024

galargh Dec 17, 2024

galargh commented Dec 17, 2024 •

edited

Loading

schaable left a comment

feat: port the node task to hardhat v3 #6025

feat: port the node task to hardhat v3 #6025

Conversation

galargh commented Dec 6, 2024 • edited Loading

Follow-ups

Testing

changeset-bot bot commented Dec 6, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Dec 6, 2024 • edited Loading

github-actions bot commented Dec 6, 2024 • edited Loading

hardhat

galargh Dec 10, 2024

Choose a reason for hiding this comment

galargh Dec 10, 2024

Choose a reason for hiding this comment

galargh commented Dec 10, 2024

schaable left a comment

Choose a reason for hiding this comment

schaable Dec 16, 2024

Choose a reason for hiding this comment

galargh Dec 17, 2024

Choose a reason for hiding this comment

galargh commented Dec 17, 2024 • edited Loading

schaable left a comment

Choose a reason for hiding this comment

galargh commented Dec 6, 2024 •

edited

Loading

changeset-bot bot commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024 •

edited

Loading

galargh commented Dec 17, 2024 •

edited

Loading