[17.0][MIG] stock_picking_analytic: Migration to 17.0 #676
Conversation
…in depends + tests
- Switch field from analytic_account_id to analytic_distribution. - Assign a dummy search arg to move_ids_without_package field (stock.picking) to bypass the warning from https://github.com/odoo/odoo/blob/0f84366/odoo/fields.py#L808-L812. - Add an invisible analytic distribution field without group assignment in the picking form, due to newly added check in odoo/odoo@0501bbd.
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_picking_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_picking_analytic/es/
Currently translated at 42.8% (3 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_picking_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_picking_analytic/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_picking_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_picking_analytic/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_picking_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_picking_analytic/it/
… distribution computation Replaced the stock picking analytic distribution search and validations with a query to improve performance when there are large amounts of picking and move records. Also, updated test to handle a case where there are different analytic accounts on moves related to a picking.
peluko00
changed the title
|
Hi @StefanRijnhart seems, it's ready to merge |
|
@peluko00 Can you rebase and drop the test requirement? |
peluko00
force-pushed
the
17.0-mig-stock_picking_analytic
branch
from
e5f2f06 to
de7b376
Compare
Done! |
| # method would trigger a warning from | ||
| # https://github.com/odoo/odoo/blob/0f84366/odoo/fields.py#L808-L812 | ||
| # pylint: disable=method-search | ||
| move_ids_without_package = fields.One2many(search="[]") |
There was a problem hiding this comment.
The field is no longer a computed field but instead a One2many field with a domain. Maybe this party trick that served us well in the past can and should be removed in this version? See https://github.com/odoo/odoo/blob/3b42467/addons/stock/models/stock_picking.py#L450-L451
There was a problem hiding this comment.
Yees, is not longer to be use. Thanks for the review
peluko00
force-pushed
the
17.0-mig-stock_picking_analytic
branch
from
de7b376 to
c73fd2f
Compare
Seems like i'ts ready to merge |
|
@peluko00 I don't think any of the PSC members of this repo have chimed in yet, so let's give it at least the 5 days until after creation of the PR that is conventional. Oca-bot will notify us when it's time. |
|
@rousseldenis can you review please |
|
@peluko00 please note that reviews and other involvement in OCA projects are on a voluntary basis and that pings are not always appreciated. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c3e4b12. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 17.0
cc https://github.com/APSL 159231
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review
Depends on: