Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] helpdesk_mgmt_sla: Migration to 16.0 #639

Open
wants to merge 26 commits into
base: 16.0
Choose a base branch
from

Conversation

LorenzoC0
Copy link

Based off #601

I've noticed an old PR was closed #450, but I don't understand the change request made by @pedrobaeza. Just for completeness I've already included it in this version.

hgarridoco and others added 25 commits October 11, 2024 17:09
Currently translated at 90.0% (27 of 30 strings)

Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_sla/es/
Currently translated at 100.0% (30 of 30 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/es_AR/
Implement more advanced rules to filter the tickets it applies to.
Additionally, the stage_id field is removed as it wasn't used.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/
Currently translated at 100.0% (73 of 73 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/es_AR/

Added translation using Weblate (Italian)
Currently translated at 100.0% (73 of 73 strings)

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/
@LorenzoC0 LorenzoC0 force-pushed the 16.0-mig-helpdesk_mgmt_sla branch from 4c50473 to e1cbe79 Compare October 11, 2024 15:27
@pedrobaeza
Copy link
Member

This claim is legit for not doing incorrect things:

#450 (comment)

so if you are repeating the same, it's not correct.

@LorenzoC0 LorenzoC0 force-pushed the 16.0-mig-helpdesk_mgmt_sla branch from e1cbe79 to 8aedd8c Compare October 15, 2024 15:21
@LorenzoC0
Copy link
Author

Hi @pedrobaeza ,
maybe I misunderstood your comment, but I removed the domain for the company_id field permanently, and wondered why it was necessary. I noticed that on Odoo core the record rule for multi-company on resource.calendar model is missing. At this point I don't think it's up to this module to add such a feature, rather it would be to create such record rule on core.
What do you think?

@pedrobaeza
Copy link
Member

What I'm just saying is that when a field protected by a groups is used in a domain, you must add the field 2 times: one with the group, and another invisible without group for not having the error. Simply that.

You don't have to remove any domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.