[15.0][IMP] Update pre commit #3875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pedrobaeza, |
EmilioPascual
force-pushed
the
15.0-update_pre-commit
branch
from
4324fde to
12fd19d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
pedrobaeza
reviewed
Jan 3, 2025
| @@ -285,7 +285,7 @@ def seur_atlas_cancel_shipment(self, pickings): | |||
|
|
|||
| def seur_atlas_get_tracking_link(self, picking): | |||
| return ( | |||
| f"https://www.seur.com/livetracking/" | |||
| f"https://www.seur.com/livetracking/" # NOQA E231 | |||
There was a problem hiding this comment.
Por qué esos comentarios NOQA? No deberían hacer falta.
There was a problem hiding this comment.
Con python3.12+ y la versión de flake8 actual en el repositorio no está solucionado. PyCQA/flake8#1845
There was a problem hiding this comment.
Entonces es un problema exclusivo de Python 3.12?
There was a problem hiding this comment.
No puedes actualizar a pycodestyle 2.11.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plantilla actualizada para que entre OCA/oca-addons-repo-template#243 y solventar error en flake8 con python3.10+