[16.0] [FIX] base_location search by display_name as in older versions

[odooNextev]

I'd propose this PR to fix this issue: #1578

I restored the old behaviour searching by display_name instead of separated fields.

[OCA-git-bot]

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[odooNextev]

Hi @pedrobaeza,
what do you think about this PR?
It downgrades search and display_name computation to the older versions (I copied from 12.0).
Why were these changed in the newer versions?

PS. If you think it's fine, how can I trigger migration script to recompute display_name on module update/upgrade?
I noticed it doesn't be triggered when you update module.
Should I rename the version folder to "16.0.1.0.2"? I guess it will be the new module version if the PR will be merged.

[pedrobaeza]

I don't think that change is sane for the DB size, as it requires to store the composed name for all the things, so I prefer to keep as it was and don't have the feature. One thing you can do is that you put this in an extra module, but I let also other's to give their opinion.

[odooNextev]

@pedrobaeza I understand your doubts.
If there aren't supporters for this PR I'll make a private extra module.
I think the only solution to keep multiple _rec_names_search and search the keywords in the search input in all the fields in the list at the same time is changing the framework core.
The best should be writing "Brussels 1000" and get "1000, Brussels, Belgium".
This can be done separating the keywords by spaces and search every of these in res.city.zip name and zip.

What do you think?
Ain't anything similar already implemented?

[pedrobaeza]

I don't know anything similar to that, sorry.

[pedrobaeza]

Other contributor has put in my radar this module: https://github.com/OCA/server-tools/tree/16.0/base_name_search_improved

Is that what you intends?

[odooNextev]

Other contributor has put in my radar this module: https://github.com/OCA/server-tools/tree/16.0/base_name_search_improved

Is that what you intends?

Thank you so much Pedro, it can be very useful!
I'll try it now

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.