[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383

Borruso · 2024-11-27T10:29:45Z

Migration from 17.0 to 18.0

Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_BR/

Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_PT/

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/gl/

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/es/

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/de/

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/pt_BR/

Currently translated at 94.1% (16 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/it/

Currently translated at 100.0% (17 of 17 strings) Translation: project-13.0/project-13.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_default_stage/ca/

Currently translated at 100.0% (20 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/es_AR/

Currently translated at 80.0% (16 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr_FR/

…sk.type

Currently translated at 100.0% (17 of 17 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr/

Currently translated at 88.2% (15 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/it/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/hr/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/de/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/it/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/pt_BR/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/es/

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/pt_BR/

- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.

zamberjo · 2024-11-27T19:39:42Z

project_task_default_stage/views/project_view.xml

+                            <field
+                                name="auto_validation_state"
+                                optional="hide"
+                                groups="project.group_project_rating"


The groups was not in previous versions, why add it?

I saw list in Odoo and Odoo add this group
I can also remove it there is no problem

No, if it is added by Odoo I see it consistent to apply the same groups.

zamberjo

Code review

coleste · 2024-12-16T21:17:41Z

project_task_default_stage/views/project_view.xml

@@ -10,8 +10,8 @@
            </field>
        </field>
    </record>
-    <record id="task_type_tree" model="ir.ui.view">
-        <field name="name">project.task.type.tree.inherit</field>
+    <record id="task_type_list" model="ir.ui.view">


That doesn't seem right. id= should be the same as that of the inherited.

coleste

LGTM

OCA-git-bot · 2024-12-18T18:19:09Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2024-12-20T08:20:32Z

/ocabot migration project_task_default_stage

rousseldenis

LGTM. Some refinements

rousseldenis · 2024-12-20T08:22:25Z

project_task_default_stage/models/project.py

+    _inherit = "project.project"
+
+    def _get_default_type_common(self):
+        ids = self.env["project.task.type"].search([("case_default", "=", True)])


IMHO, ids should be renamed (records or task_types or ...) as it is not ids

rousseldenis · 2024-12-20T08:22:37Z

project_task_default_stage/models/project.py

+        ids = self.env["project.task.type"].search([("case_default", "=", True)])
+        return ids
+
+    type_ids = fields.Many2many(default=lambda self: self._get_default_type_common())


Please put field on top

rousseldenis · 2024-12-20T08:23:42Z

project_task_default_stage/tests/test_project_task_default_stage.py

+from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+
+
+class TestProjectCaseDefault(TransactionCase):


FYI, you can inherit from BaseCommon class instead to avoid context line.

sergio-teruel and others added 30 commits November 27, 2024 11:20

[NEW][9.0] project_task_default_stage: Default stages for new projects.

f8ba7ce

[MIG] Make modules uninstallable

5d63720

[MIG] Rename manifest files

b0e62ad

[MIG] 10.0 port project_task_default_stage (OCA#201)

e4f67d3

Added default stage to tree view

71dfcec

[MIG] project_task_default_stage: Migration to 11.0

015b321

Translated using Weblate (Português (Brasil))

7472c86

Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_BR/

Update tr.po

ef8ee20

[MIG] project_task_default_stage: Migration to 12.0

3fecebc

Translated using Weblate (Galician)

534b01b

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/gl/

Translated using Weblate (Spanish)

ecf0c31

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/es/

Translated using Weblate (German)

eb7275b

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/de/

Translated using Weblate (Portuguese (Brazil))

7e4d36c

Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/pt_BR/

Translated using Weblate (Italian)

4d0f24c

Currently translated at 94.1% (16 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/it/

[IMP] project_task_default_stage: black, isort

10deffc

[MIG] project_task_default_stage: Migration to 13.0

853526e

Translated using Weblate (Catalan)

ba228ff

Currently translated at 100.0% (17 of 17 strings) Translation: project-13.0/project-13.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_default_stage/ca/

[MIG] project_task_default_stage: Migration to 14.0

ef26e87

Added translation using Weblate (Spanish (Argentina))

44c40e4

Translated using Weblate (Spanish (Argentina))

bccf1e1

Currently translated at 100.0% (20 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/es_AR/

Added translation using Weblate (French (France))

d5caf68

Translated using Weblate (French (France))

08f09fa

Currently translated at 80.0% (16 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr_FR/

[FIX] Add custom embedded tree view in project.project for project.ta…

c53274f

…sk.type

Translated using Weblate (French)

0260fb2

Currently translated at 100.0% (17 of 17 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr/

[MIG] project_task_default_stage : Migration to 15.0

68d7259

[MIG] project_task_default_stage: Migration to 16.0

453aec1

Translated using Weblate (Italian)

24a91a5

Currently translated at 88.2% (15 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/it/

Translated using Weblate (Croatian)

53f0677

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/hr/

Translated using Weblate (German)

1b7f414

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/de/

mymage and others added 7 commits November 27, 2024 11:23

Translated using Weblate (Italian)

1dff1d9

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/it/

Translated using Weblate (Portuguese (Brazil))

bb51a09

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/pt_BR/

Translated using Weblate (Spanish)

8edcf59

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/es/

Translated using Weblate (Portuguese (Brazil))

2c13261

Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/pt_BR/

[IMP] project_task_default_stage: test performance improvement

c21a1f6

- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.

[IMP] project_task_default_stage: pre-commit auto fixes

819264d

[MIG] project_task_default_stage: Migration to 17.0

edbf8c4

Borruso force-pushed the 18.0-mig-project_task_default_stage branch from 418d38d to 79875ec Compare November 27, 2024 10:40

zamberjo reviewed Nov 27, 2024

View reviewed changes

zamberjo approved these changes Nov 28, 2024

View reviewed changes

coleste reviewed Dec 16, 2024

View reviewed changes

Borruso force-pushed the 18.0-mig-project_task_default_stage branch from 79875ec to 3da8cda Compare December 17, 2024 09:08

coleste approved these changes Dec 18, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 18, 2024

OCA-git-bot added this to the 18.0 milestone Dec 20, 2024

OCA-git-bot mentioned this pull request Dec 20, 2024

Migration to version 18.0 #1347

Open

10 tasks

rousseldenis requested changes Dec 20, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Dec 20, 2024

[MIG] project_task_default_stage: Migration to 18.0

49dff3f

Borruso force-pushed the 18.0-mig-project_task_default_stage branch from 3da8cda to 49dff3f Compare December 20, 2024 10:20

Borruso requested a review from rousseldenis December 20, 2024 10:20

pedrobaeza mentioned this pull request Dec 20, 2024

[18.0][MIG] project_task_default_stage: Migration to 18.0 #1401

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383

[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383

Borruso commented Nov 27, 2024

zamberjo Nov 27, 2024 •

edited

Loading

Borruso Nov 28, 2024

zamberjo Nov 28, 2024

zamberjo left a comment

coleste Dec 16, 2024

coleste left a comment

OCA-git-bot commented Dec 18, 2024

rousseldenis commented Dec 20, 2024

rousseldenis left a comment

rousseldenis Dec 20, 2024

rousseldenis Dec 20, 2024

rousseldenis Dec 20, 2024

		from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT


		class TestProjectCaseDefault(TransactionCase):

[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383

Are you sure you want to change the base?

[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383

Conversation

Borruso commented Nov 27, 2024

zamberjo Nov 27, 2024 • edited Loading

Choose a reason for hiding this comment

Borruso Nov 28, 2024

Choose a reason for hiding this comment

zamberjo Nov 28, 2024

Choose a reason for hiding this comment

zamberjo left a comment

Choose a reason for hiding this comment

coleste Dec 16, 2024

Choose a reason for hiding this comment

coleste left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 18, 2024

rousseldenis commented Dec 20, 2024

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis Dec 20, 2024

Choose a reason for hiding this comment

rousseldenis Dec 20, 2024

Choose a reason for hiding this comment

rousseldenis Dec 20, 2024

Choose a reason for hiding this comment

zamberjo Nov 27, 2024 •

edited

Loading