Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0] base_rest: Migration to 15.0 #225

Merged
merged 1 commit into from
Dec 2, 2021
Merged

[MIG][15.0] base_rest: Migration to 15.0 #225

merged 1 commit into from
Dec 2, 2021

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Nov 24, 2021 •
edited
Loading

No description provided.

@yankinmax yankinmax force-pushed the 15.0-mig-base_rest branch 4 times, most recently from 389650b to ad21453 Compare November 26, 2021 10:49
@yankinmax yankinmax mentioned this pull request Nov 26, 2021
Merged
1 task
@yankinmax
Copy link
Contributor Author

@simahawk @lmignon could you pls approve running workflow to proceed further?

simahawk
simahawk reviewed Nov 29, 2021
View reviewed changes
oca_dependencies.txt Outdated Show resolved Hide resolved
@yankinmax yankinmax force-pushed the 15.0-mig-base_rest branch 3 times, most recently from 585fc7d to 0c55bcd Compare November 29, 2021 12:06
@yankinmax yankinmax force-pushed the 15.0-mig-base_rest branch 3 times, most recently from 9244882 to 592bf46 Compare November 30, 2021 17:00
@yankinmax
Copy link
Contributor Author

@lmignon can you pls help, how to make it always running all check tests?

@simahawk
Copy link
Contributor

simahawk commented Dec 1, 2021

@lmignon can you pls help, how to make it always running all check tests?

we cannot do anything about it AFAIK

@yankinmax
Copy link
Contributor Author

so I should always ask to approve workflow?

@simahawk
Copy link
Contributor

simahawk commented Dec 1, 2021

Reason https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@yankinmax
Copy link
Contributor Author

Reason https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

thanks for the link

@yankinmax
Copy link
Contributor Author

@simahawk so, from what I see now, there is no codecov message if "Files changed". I need to improve tests.

lmignon
lmignon approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the migration. LGTM (Code review only)

This was referenced Dec 1, 2021
Merged
Merged
Closed
@lmignon lmignon mentioned this pull request Dec 2, 2021
Closed
10 tasks
simahawk
simahawk approved these changes Dec 2, 2021
View reviewed changes
base_rest/http.py Outdated Show resolved Hide resolved
simahawk
simahawk requested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback the noqa

@simahawk
Copy link
Contributor

simahawk commented Dec 2, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-225-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e693cee into OCA:15.0 Dec 2, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e6ff50c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankinmax @simahawk @OCA-git-bot @lmignon