[14.0] connector_search_engine: keep data for bindins to check #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
14-fix-to-be-checked
branch
from
fb3e69d to
6302d6f
Compare
To help checking what the problem might be do not skip storing the computed data.
Before this change the error was visible only in the job if not deleted. This we can provide more info to the end user w/o the need for a new field. This info will be wiped on the next successful compute.
simahawk
force-pushed
the
14-fix-to-be-checked
branch
from
6302d6f to
0a7bf69
Compare
simahawk
commented
May 9, 2024
| vals = {"data": index_record} | ||
| if binding.sync_state != "to_update": | ||
| vals["sync_state"] = "to_update" | ||
| vals["date_modified"] = fields.Datetime.now() | ||
| if error: | ||
| vals["sync_state"] = "to_be_checked" | ||
| vals["data"]["__error__"] = error |
There was a problem hiding this comment.
Of course it would be better to have a specific field. However:
- we could have tons of records on different models
- in a pre-migrate step you don't have at hand all the models that could inherit from the mixin as they are not loaded yet
- we cannot safely add the field via sql to all the tables that would need it
Or, at least, I don't have a smart way to do it...
This is better than nothing for now :)
Any recommendation?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help checking what the problem might be
do not skip storing the computed data.