Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] email_template_configurator #1278

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

marielejeune
Copy link

This module implements a simpler interface for the email template dynamic fields. A configurator allows the creation of predefined named replacement strings, which can then be selected in the template.

NB: This module works in production at Acsone since several years. :-)

@marielejeune marielejeune changed the title [ADD] email_template_configurator [14.0][ADD] email_template_configurator Jan 9, 2024
@marielejeune marielejeune force-pushed the 14.0-email_template_configurator-mle branch from 028559e to c448f90 Compare January 9, 2024 14:00
@marielejeune marielejeune marked this pull request as draft January 9, 2024 14:01
@marielejeune marielejeune force-pushed the 14.0-email_template_configurator-mle branch from c448f90 to 696bb67 Compare January 9, 2024 14:06
@marielejeune marielejeune marked this pull request as ready for review January 9, 2024 14:12
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@github-actions github-actions bot closed this Jul 21, 2024
@marielejeune
Copy link
Author

@sbidoul can you reopen and add the no stale label please?
As this is used in production for years now, and it has a positive review, we may even merge this? :-)

@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2024

/ocabot merge nobump

@sbidoul sbidoul reopened this Dec 16, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1278-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 16, 2024
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

@sbidoul The merge process could not be finalized, because command twine check odoo14_addon_email_template_configurator-14.0.1.0.1.dev2-py3-none-any.whl failed with output:

Checking 
odoo14_addon_email_template_configurator-14.0.1.0.1.dev2-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         No content rendered from RST source.                                   
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2024

@marielejeune this modules lacks a DESCRIPTION.rst

@marielejeune marielejeune force-pushed the 14.0-email_template_configurator-mle branch from 696bb67 to 8273b79 Compare December 17, 2024 07:44
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants