Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method #1450

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

andrel-exo
Copy link

This fix replaces the use of deprecated methods _get_default_mail_partner_cc_ids and _get_default_mail_partner_bcc_ids with the correct method _get_partner_ids_from_mail suggested here #1312.

Impact: Without this PR, the app cannot be used. When trying to send an email from an invoice, an error occurs immediately because the old methods no longer exist.

@OCA-git-bot
Copy link
Contributor

Hi @hailangvn2023,
some modules you are maintaining are being modified, check this out!

@andrel-exo andrel-exo changed the title [17.0][FIX] use _get_partner_ids_from_mail method [17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method Sep 30, 2024
Copy link
Contributor

@trisdoan trisdoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants