-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] mail_gateway_whatsapp: Add support for WhatsApp templates #1497
base: 16.0
Are you sure you want to change the base?
[16.0][IMP] mail_gateway_whatsapp: Add support for WhatsApp templates #1497
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
If the company wants to initiate a conversation with a customer, a template must be used; otherwise, messages will not be sent. This also applies when the last conversation with the customer is older than 24 hours. - Enabled downloading templates from META - Added the ability to create templates directly in Odoo. Note: Currently, templates with variables or buttons are not supported.
This comment was marked as off-topic.
This comment was marked as off-topic.
067229c
to
843eb4f
Compare
I fixed the test issues related to the module |
…ated to the current user - Use OdooBot for webhooks instead of the current user, following the same logic as Odoo. - Avoid automatically adding the current user as a member of a new gateway to prevent notifications for all messages. This is now an explicit configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a technical Level LGTM
help="User that will create the messages", | ||
) | ||
member_ids = fields.Many2many( | ||
"res.users", default=lambda self: [Command.link(self.env.user.id)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this changes are the reason behind the test issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this changes are the reason behind the test issue
The CI has been failing for several days on all PRs/commits in V16.
The last commit is unrelated to WhatsApp templates. If you prefer, I can create a new PR for it separately. However, this commit is not linked to the tests but addresses a different case, please refer to the commit description for more details.
Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review and functional test).
CI is working in main branch, can you apply my suggestion and rebase? |
If the company wants to initiate a conversation with a customer, a template must be used; otherwise, messages will not be sent. This also applies when the last conversation with the customer is older than 24 hours.
Note: Currently does not support templates with variables or buttons
TT51660
@Tecnativa @pedrobaeza @chienandalu @etobella could you please review this