[16.0][FIX] mail_show_follower: Company identification in _send() #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, 'Show Internal Users CC' would always be False, regardless of the setting in the company, in case the message came from a record with a company_id field but without a value assignment to it (e.g., a partner record with no company), as company would be an empty record. This commit fixes the behavior by capturing company from self.env in these cases.
|
Hi @yajo, |
nobuQuartile
changed the title
pedrobaeza
approved these changes
Dec 5, 2024
hbrunn
approved these changes
Dec 6, 2024
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 11, 2024
|
@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1517-by-yajo-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
test are fixed in #1519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, 'Show Internal Users CC' would always be False, regardless of the setting in the company, in case the message came from a record with a company_id field but without a value assignment to it (e.g., a partner record with no company), as company would be an empty record.
This commit fixes the behavior by capturing company from self.env in these cases.
@qrtl QT5021