Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] help on web repo to apply last pre-commit changes #3044

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

xaviedoanhduy
Copy link

No description provided.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point the issue you're fixing? Is that reordering happening automatically or something?

@xaviedoanhduy
Copy link
Author

Can you point the issue you're fixing? Is that reordering happening automatically or something?

yes, have a warning in CI when run pre-commit run -a

prettier (with plugin-xml)...............................................Passed
eslint...................................................................Passed
- hook id: eslint
- duration: 0.61s


/home/trobz/code/oca/web/18.0/web_tree_many2one_clickable/static/src/components/many2one_button/many2one_button.esm.js
  11:1  warning  Imports should be sorted alphabetically  sort-imports

✖ 1 problem (0 errors, 1 warning)


trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

(how I hate that rule! 😅 )

@pedrobaeza pedrobaeza added this to the 18.0 milestone Dec 31, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3044-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5ddff7 into OCA:18.0 Dec 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d43016d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants