Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] web_theme_classic: Migration to 18.0 #3045

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] web_theme_classic: Migration to 18.0 #3045

wants to merge 23 commits into from

Conversation

dedinside1337
Copy link

No description provided.

legalsylvain and others added 22 commits January 2, 2025 15:20
@legalsylvain
[ADD] new module web_theme_classic to identify better buttons and fie…
2f1ff30 
…lds in Odoo form views
[UPD] Update web_theme_classic.pot
fc1af58
@OCA-git-bot
[UPD] README.rst
7ecfbdb
@OCA-git-bot
[ADD] icon.png
c072b3e
@legalsylvain
[IMP] web_theme_classic : Do not display required color on readonly f…
c05a13c 
…ields
@legalsylvain
[IMP] web_theme_classic : Do not set border-bottom to required field,…
00bfa7f 
… as the field has now a background-color
@OCA-git-bot
web_theme_classic 16.0.1.0.2
ff8a6fc
@OCA-git-bot
[UPD] README.rst
4e23bdd
@remi-filament
Added translation using Weblate (French)
4f2e298
@remi-filament
Deleted translation using Weblate (French)
b3f9d09
@legalsylvain
[IMP] web_theme_classic: black, isort, prettier
ceba6e9
@legalsylvain
[MIG] web_theme_classic from 16.0 to 17.0
4284d23
@legalsylvain
[REF] use new readme conventions. (replace rst by md files)
4bfa6a5
@gandalfthegreydev
add some pixels left/right on input fields
e6ed542
@legalsylvain @remi-filament
[FIX] web_theme_classic : remove obsolete xml declaration.
fcdfc8f 
Co-authored-by: Rémi <[email protected]>
[UPD] Update web_theme_classic.pot
e098321
@OCA-git-bot
[BOT] post-merge updates
f3e6dd0
@mymage
Added translation using Weblate (Italian)
9990f43
[MIG] web_theme_classic: Migration to 18.0
098baf9
[MIG] web_theme_classic: Migration to 18.0
68ed358 
[MIG] web_theme_classic: Migration to 18.0
[MIG] web_theme_classic: Migration to 18.0
1a8fe59
[MIG] web_theme_classic: Migration to 18.0
eff8b80 
[MIG] web_theme_classic: Migration to 18.0
@legalsylvain
Copy link
Contributor

legalsylvain commented Jan 2, 2025 •
edited
Loading

Hi. Thanks for porting this module. Could you take a look on pre-commit errors ?

Thanks !

rvalyi
rvalyi requested changes Jan 4, 2025
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you fixed the pre-commit. However, you should now use something like git rebase -i HEAD~6 to squash the last 5 migration commits into a single one. Indeed it's important to keep simple migrations in a single atomic commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dedinside1337 @legalsylvain @rvalyi @OCA-git-bot @remi-filament @gandalfthegreydev @mymage