Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_form_require_legal: Migration to version 16.0 #1003

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Aug 8, 2023

cc @Tecnativa TT44376

@chienandalu @CarlosRoca13 please review

@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as draft August 8, 2023 15:42
@pedrobaeza
Copy link
Member

/ocabot migration website_form_require_legal

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 8, 2023
13 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_form_require_legal branch from 5c6f34a to f642fbe Compare November 6, 2023 23:18
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review November 6, 2023 23:19
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong...

error_include

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_form_require_legal branch from f642fbe to 68fbc4b Compare November 7, 2023 07:26
@pilarvargas-tecnativa
Copy link
Author

Something is wrong...

I tried again locally, it should no longer happen

@CarlosRoca13
Copy link
Contributor

I have found another error: error_classlist

@pilarvargas-tecnativa
Copy link
Author

pilarvargas-tecnativa commented Nov 7, 2023

I have found another error:

is a error in the website_crm_privacy_policy module, it is corrected at #1014

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_form_require_legal branch from 68fbc4b to d2202f3 Compare November 9, 2023 06:53
@pilarvargas-tecnativa
Copy link
Author

@CarlosRoca13 The error you were experiencing in runbot in the contact form is already fixed in the other module, however the functionality test has to be done by inserting a new form block as the other module already has the contact form customised and only allows editing the link. In local tests where the two modules do not coexist, the functionality is also applied to the contact form, so to check that it really works you would have to do it without the other module marked as "deprecated" installed.

Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1003-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 59f79d9 into OCA:16.0 Nov 14, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at facc049. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-website_form_require_legal branch November 14, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants