Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] website_odoo_debranding: Migration to 18.0 #1065

Open
wants to merge 29 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] website_odoo_debranding: Migration to 18.0 #1065

wants to merge 29 commits into from

Conversation

NICO-SOLUTIONS
Copy link
Member

standard migration

cubells and others added 28 commits October 22, 2024 15:00
@cubells @NICO-SOLUTIONS
[MIG] website_disable_odoo migration
b7a910b 
* Imported last updates from v8
* Adapted to v9
* Renamed to website_odoo_debranding
* Updated README
@pedrobaeza @NICO-SOLUTIONS
[FIX] website_odoo_debranding: runbot link
1ed2cdf
@yajo @NICO-SOLUTIONS
[MIG][website_odoo_debranding] Migrate to v10
3fbba2d 
- Relicensed to LGPL.
- The template that does the job can be disabled by the admin.
@ddufresne @NICO-SOLUTIONS
[MIG][11.0] website_odoo_debranding
b270e37
@oca-travis @NICO-SOLUTIONS
[UPD] Update website_odoo_debranding.pot
2fbce89
@karan-dreambits @NICO-SOLUTIONS
[MIG] website_odoo_debranding: Migration to 12.0
51b7adb
@oca-travis @NICO-SOLUTIONS
[UPD] Update website_odoo_debranding.pot
79eb9a8
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
c59cb67
@Tardo @NICO-SOLUTIONS
[IMP] website_odoo_debranding: black, isort, prettier
2dd176d
@ougc27 @NICO-SOLUTIONS
[MIG] website_odoo_debranding: Migration to 13.0
683bd85
@oca-travis @NICO-SOLUTIONS
[UPD] Update website_odoo_debranding.pot
4f80fb4
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
21dae74
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
19e86ca
@dsolanki-initos @NICO-SOLUTIONS
[MIG] Migrate module website_odoo_debranding to v14.
a0358dc
@oca-travis @NICO-SOLUTIONS
[UPD] Update website_odoo_debranding.pot
9df4d84
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
c1b0020
@ibuioli @NICO-SOLUTIONS
Added translation using Weblate (Spanish (Argentina))
44a2a33
@nabilragab @NICO-SOLUTIONS
[IMP] website_odoo_debranding: black, isort, prettier
f2a9d9d
@NICO-SOLUTIONS
[UPD] Update website_odoo_debranding.pot
074692e
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
683f458
@dhx @NICO-SOLUTIONS
[IMP] website_odoo_debranding: Avoid deprecation warning with 'Enviro…
85bc94a 
…nment.manage()'

Closes OCA#899
@OCA-git-bot @NICO-SOLUTIONS
website_odoo_debranding 15.0.1.0.1
8859176
@yibudak @NICO-SOLUTIONS
[MIG] website_odoo_debranding: Migration to 16.0
73be3b3 
[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_odoo_debranding
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_odoo_debranding/

[UPD] README.rst
@pedrobaeza @NICO-SOLUTIONS
[FIX] Update copier template + linter fix
17552a5
@NICO-SOLUTIONS
[IMP] website_odoo_debranding: pre-commit auto fixes
a9c0a1d
@NICO-SOLUTIONS
[MIG] website_odoo_debranding: Migration to 17.0
d2c21fd
@NICO-SOLUTIONS
[FIX] inherit problems with planning enterprise module
03fcdd2 
With website_odoo_debranding installed it was not possible to install enterprise planning. Planning relies on <t t-call="web.brand_promotion_message"> sections which was removed with replacing the o_brand_promotion.

[UPD] Update website_odoo_debranding.pot

[BOT] post-merge updates
@mymage @NICO-SOLUTIONS
Added translation using Weblate (Italian)
2e79a8c
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_odoo_debranding branch from f03bd29 to 5aa5de0 Compare November 9, 2024 11:20
@BurkhalterY
Copy link
Member

Hi, I think this PR could be mark as ready. Threre is no breaking change at this point. What do you think? :)

@NICO-SOLUTIONS
Copy link
Member Author

Hi, I think this PR could be mark as ready. Threre is no breaking change at this point. What do you think? :)

Just havent had the time to check the failing tests. But this is not related to the module

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review November 20, 2024 07:04
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Nov 20, 2024
Open
5 tasks
@pedrobaeza
Copy link
Member

The failure is for having this warning:

WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo'

The workaround is to have an empty dummy test.

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_odoo_debranding branch from 5aa5de0 to ecaa1e2 Compare November 20, 2024 08:26
@NICO-SOLUTIONS
Copy link
Member Author

The failure is for having this warning:

WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo'

The workaround is to have an empty dummy test.

@pedrobaeza ahh many thanks for the hint. Added the dummy test.
What about the "[IMP] website_odoo_debranding: pre-commit auto fixes" commit. There was no change by pre-commit. Better to squash this into the migration commit or keep it?

@pedrobaeza
Copy link
Member

Yes, remove that commit. I think you have added --allow-empty on your command line to have that commit.

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 18.0-mig-website_odoo_debranding branch from ecaa1e2 to 0fa3708 Compare November 20, 2024 08:52
@NICO-SOLUTIONS
Copy link
Member Author

Yes, remove that commit. I think you have added --allow-empty on your command line to have that commit.

this is correct. i was not sure how to handle the no-change, so added this commit temporarily.
its removed now. thx!

mymage
mymage approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on RunBoat and at first access I see this on the bottom right:
immagine
I tried to replicate it, moving on the other site and creating a new one, switching dev mode on/off. In one occasion it appears after changing the site language.
Unfortunately I am not able to reproduce a step sequence that causes this behaviour.

@NICO-SOLUTIONS
Copy link
Member Author

NICO-SOLUTIONS commented Dec 12, 2024 •
edited
Loading

I tested it on RunBoat and at first access I see this on the bottom right: immagine I tried to replicate it, moving on the other site and creating a new one, switching dev mode on/off. In one occasion it appears after changing the site language. Unfortunately I am not able to reproduce a step sequence that causes this behaviour.

you need to activate it for the website in the website builder editor

edit

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurkhalterY BurkhalterY BurkhalterY approved these changes

@mymage mymage mymage approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.