[17.0][MIG] website_search_header: Migration to 17.0

[kobros-tech]

This module is upgraded from the pull #1000 of version 16.0 but is closed.

I don't know why it is not merged, but I make this pull to share the upgraded version if someone needs it.

I have made modifications on the module in JavaScript, if possible we cooperate again and modify the 16.0 version and try to merge it again.

I looking forward to hearing from you...

@JordiBForgeFlow
@ioans73
@pedrobaeza

ets/2606e76c-059e-4ea5-a382-3b972b2c6c2c)

[pedrobaeza]

Don't lose commit history.

[kobros-tech]

Don't lose commit history.

Hello @pedrobaeza
Nice to meet you :)

I guess, I did not catch up what you mean.

I see the module pull for 16.0 is closed and we are depending on it for the upper versions up to 18.0

I need to share with the author to make the closed pull request succeeds, but I did not understand as I am still new in the community.

[pedrobaeza]

Yes, but you have put only one commit, instead of starting from the previous commit history with the initial commit from Jordi, and the rest. This is for preserving the attribution.

[kobros-tech]

Yes, but you have put only one commit, instead of starting from the previous commit history with the initial commit from Jordi, and the rest. This is for preserving the attribution.

Thanks for clarifications :)
Let me check and fix it.

[kobros-tech]

Can I fix the issues in the last commit of version 16.0 and make a pull request for him and through this his pull will be merged, then mine.

Or I can just merge this pull if I add the the last commit.

[pedrobaeza]

With some git fu, you can keep this PR, rewriting the commit history. Save your current files in another location, reset your last commit, and start getting the commit history using a variation of the command in here:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch

changing the remote to the one of the initial PR.

Then, recopy your files and commit the migration itself.

[ioans73]

@kobros-tech is this module really necessary? In version 17.0 we already have a default website search

cc @pedrobaeza @JordiBForgeFlow

[kobros-tech]

I just put it to refer and it is now deprecated after the PR of my boss, #1071

[kobros-tech]

Dear Mr. @pedrobaeza after tiring job I could keep the log as it should be.

I used git aggregator to keep the log of the authors, then I continued with my hand.
It was hard at the begging to be familiar with this tool, but thanks for having git aggregator!

No very need to merge, although it looks nice and useful.

[pedrobaeza]

Great, thanks for the efforts. Let's see the comments of the reviewers.